[Remove Vuetify from Studio] Buttons/links in Import from channels#5467
Merged
MisRob merged 2 commits intolearningequality:hotfixesfrom Oct 21, 2025
Merged
[Remove Vuetify from Studio] Buttons/links in Import from channels#5467MisRob merged 2 commits intolearningequality:hotfixesfrom
MisRob merged 2 commits intolearningequality:hotfixesfrom
Conversation
MisRob
changed the title
Member
|
Thank you @Abhishek-Punhani, we will assign a reviewer next week. |
Signed-off-by: Abhishek-Punhani <punhani.manavabhi@gmail.com>
MisRob
approved these changes
Oct 20, 2025
Member
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Hi @Abhishek-Punhani, thank you, code changes make sense and all interactions work as expected.
I rebased your branch to hotfixes because it will help us with a bug that we want to fix soon (but generally, unstable is indeed the right branch for this project). I noticed there was only one forgotten VBtn so I replaced it by KButton too on this opportunity.
After I confirm with release managers, we will merge. Thanks!
Member
|
Related issue #5406 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionLinkandVBtnwithKButton…
References
Fixes #5444
…
Reviewer guidance
…