add focus trapping to resource preview side panel#5400
Merged
akolson merged 1 commit intolearningequality:hotfixesfrom Sep 22, 2025
Merged
add focus trapping to resource preview side panel#5400akolson merged 1 commit intolearningequality:hotfixesfrom
akolson merged 1 commit intolearningequality:hotfixesfrom
Conversation
marcellamaki
approved these changes
Sep 22, 2025
Member
marcellamaki
left a comment
There was a problem hiding this comment.
Code changes are nice and easy to read, and seem like a good approach for the near term, and the focus trap does seem to be working fine. I think in some places the focus outline is getting "lost" briefly (it seems like for some items, there is an extra tab required to move between focuable elements), but I think this is a good improvement, and we can address some other optimizations in follow up. (cc @radinamatic)
This was referenced Sep 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr adds focus trapping to the resource preview side panel displayed when importing resources from other channels. It uses the
useFocusTrapcomposable (implemened by @habibayman, Thank you! 🙂).Note: This seems like best way to resolve the bug for now, however, ultimately, we'll want to migrate the side panel from Vuetify so we can take advantage of the
KFocusTrapcomponent, which won't work out of the box with the current side panel implementation.Before

After
Screen.Recording.2025-09-18.at.13.07.11.mov
References
Fixes #5269
Reviewer guidance