Fix regression for perseus exercise image export#5399
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Sep 18, 2025
Merged
Fix regression for perseus exercise image export#5399rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles merged 1 commit intolearningequality:hotfixesfrom
Conversation
akolson
requested changes
Sep 18, 2025
Member
akolson
left a comment
akolson
left a comment
There was a problem hiding this comment.
Changes look correct to me! However it seems like the minio is not being set up conclusively so the tests are not being run. It returns the error below in the Setup minio step;
Unable to find image 'bitnami/minio:2024.5.28' locally
Member
Member
Author
|
Yes. |
…n the question_images dict as keys, rather than just filenames.
rtibbles
force-pushed
the
its_all_about_image_darling
branch
from
6755a2d to
1073bd1
Compare
Member
Author
|
Rebased and force pushed. |
akolson
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #5398
Reviewer guidance
Confirmed by importing to Kolibri locally
Generate an exercise without free response questions. Include an image in the question body. Ensure that the imported question displays when imported to Kolibri as per above.
The regression test was written by Claude Code and then edited to provide a more straightforward and explicit assertion.