Fixes additional resource preview Klogo loading issues#5367
Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom Sep 9, 2025
Merged
Fixes additional resource preview Klogo loading issues#5367marcellamaki merged 1 commit intolearningequality:hotfixesfrom
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
Conversation
marcellamaki
approved these changes
Sep 9, 2025
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
I've tested the supported content types as well as some of the unsupported content types, and everything seems to be the expected behavior, and the code changes make sense to me.
Merged
Member
|
Thanks @akolson LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr prevents the
KLogofrom loading endlessly whenbloompub,bloomd,h5p, andkpubfile types are loaded.References
Fixes #5327
Reviewer guidance