Do not use hardcoded colors in 'Request more space' form#5195
Merged
MisRob merged 2 commits intolearningequality:unstablefrom Jul 25, 2025
Merged
Do not use hardcoded colors in 'Request more space' form#5195MisRob merged 2 commits intolearningequality:unstablefrom
MisRob merged 2 commits intolearningequality:unstablefrom
Conversation
Member
|
Hi @yeshwanth235, thanks! Overall looks aligned with expectations, I will review in detail soon. |
MisRob
changed the title
MisRob
reviewed
Jul 24, 2025
Member
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Hi @yeshwanth235, looks well, thank you! Just one adjustment is needed before we merge.
| {{ $tr('fieldRequiredText') }} | ||
| </div> | ||
| <label :style="{ color: orgSelected ? 'black' : 'gray' }"> | ||
| <label :style="{ color: orgSelected ? $themePalette.black : $themePalette.grey.v_300 }"> |
Member
There was a problem hiding this comment.
Even though the output colors are just fine, for black text, it'd be most appropriate to use tokens.text. And for gray one, tokens.textDisabled. palette is more suitable when there's no token available that would hold contextual information about a color usage.
MisRob
approved these changes
Jul 25, 2025
Member
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
All is well, thank you @yeshwanth235
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found three place which uses hardcoded colors in Storage/RequestForm. Updated them to KDS tokens
References
5094
Reviewer guidance
Check everything is working as expected.
Impacted area in requestForm. Check for below fields