Feedback utility functions#5088
Merged
bjester merged 22 commits intolearningequality:unstablefrom Jul 29, 2025
Merged
Conversation
ozer550
previously requested changes
Jun 9, 2025
Member
ozer550
left a comment
There was a problem hiding this comment.
Logically, everything in the code makes sense! Just a few small tweaks and some debugging is needed to resolve the UI issues encountered during testing. Additionally, I have a few thoughts on potential optimizations we could explore further.
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Outdated
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Outdated
Show resolved
Hide resolved
...tion/contentcuration/frontend/RecommendedResourceCard/components/RecommendedResourceCard.vue
Show resolved
Hide resolved
bjester
reviewed
Jun 9, 2025
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Outdated
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Show resolved
Hide resolved
akolson
commented
Jun 12, 2025
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Outdated
Show resolved
Hide resolved
a8759bb to
02b5952
Compare
bjester
requested changes
Jul 8, 2025
Member
bjester
left a comment
There was a problem hiding this comment.
Unless I'm missing something, the event ordering seems misaligned.
Additionally, there's a confusing mix of async/await, old-style Promise chaining, and some ignored promises. I suggest some consistency, with code comments for explaining the purposes of any inconsistencies-- if a promise is ignored, give a reason. For new code, I see no reason not to use async/await
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Outdated
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Outdated
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue
Outdated
Show resolved
Hide resolved
5e48e3d to
c793fc9
Compare
…t during pagination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr does the following;
References
Fixes #5057
Fixes #5058
Fixes #5088
Reviewer guidance
RecommendationsEventandRecommendationsInteractionEventmodels