Remove stylus module replacement causing non-hot devserver to break#5035
Merged
rtibbles merged 2 commits intolearningequality:unstablefrom Apr 29, 2025
Merged
Remove stylus module replacement causing non-hot devserver to break#5035rtibbles merged 2 commits intolearningequality:unstablefrom
rtibbles merged 2 commits intolearningequality:unstablefrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the module replacement for Vuetify's stylus files from the webpack configuration, addressing errors encountered in non-hot devserver builds.
- Removed unused webpack import
- Removed conditional module replacement plugin for Vuetify stylus files
Comments suppressed due to low confidence (1)
webpack.config.js:177
- Confirm that removing the module replacement for Vuetify's stylus files does not adversely impact other build configurations. Verify that the dummyModule is not referenced elsewhere, ensuring consistency across both non-hot and hot devserver modes.
].concat( hot ? [] : [ new webpack.NormalModuleReplacementPlugin(/vuetify\/src\/stylus\//, dummyModule) ])
65edb05 to
d495836
Compare
rtibbles
approved these changes
Apr 29, 2025
Member
rtibbles
left a comment
There was a problem hiding this comment.
No issues observed with either hot or non-hot devserver with this change. Good to cleanup random fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Historically, we've had some module replacement in our webpack config for Vuetify's stylus files. At one point, it was always enabled (hot and non-hot devservers), then we made it only enabled for non-hot, and now the solution seems to be to remove it entirely.
The issue was that running
pnpm run devservercomplained about.stylfiles:References
#4119
Reviewer guidance
Ran the following, observed no errors:
pnpm run devserverpnpm run devserver:hot