Update JS constants for le-utils latest.#5027
Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom Apr 29, 2025
Merged
Update JS constants for le-utils latest.#5027marcellamaki merged 1 commit intolearningequality:hotfixesfrom
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
Conversation
Amend file upload test to be less brittle.
rtibbles
force-pushed
the
update_le_utils_in_js
branch
from
1d02402 to
2751fb7
Compare
marcellamaki
approved these changes
Apr 29, 2025
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
Code changes look good to me, and manual testing confirms a kpub successfully uploads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary