Merged
Conversation
Welcome Embeddings 🚀
Allow docker build on push to `search-recommendations`
Core functionality of `connect` and `make_request` methods on `Backend` class
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akolson
commented
Apr 17, 2025
akolson
commented
Apr 17, 2025
Search recommendations branch cleanups
bjester
approved these changes
Apr 22, 2025
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Most recent PR took care of the remaining outstanding items. LGTM
Adds go to navigation to recommended resource card popout icon
bjester
reviewed
Apr 23, 2025
...tion/contentcuration/frontend/RecommendedResourceCard/components/RecommendedResourceCard.vue
Outdated
Show resolved
Hide resolved
...tion/contentcuration/frontend/RecommendedResourceCard/components/RecommendedResourceCard.vue
Show resolved
Hide resolved
bjester
reviewed
Apr 23, 2025
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Furthering the comments on exception logging-- seems like we have redundant logging of exceptions and I question the accuracy of some of the catches
bjester
reviewed
Apr 23, 2025
More tweaks from #5014 review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr merges the search recommendations feature into unstable
References
#4044
Reviewer guidance
Figma designs