Interpolate scss variables in calc functions#4994
Merged
akolson merged 1 commit intolearningequality:unstablefrom Apr 10, 2025
Merged
Interpolate scss variables in calc functions#4994akolson merged 1 commit intolearningequality:unstablefrom
akolson merged 1 commit intolearningequality:unstablefrom
Conversation
AlexVelezLl
changed the title
akolson
approved these changes
Apr 10, 2025
Member
akolson
left a comment
akolson
left a comment
There was a problem hiding this comment.
Changes look correct to me! Thanks @AlexVelezLl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the migration from less to scss, we were missing the scss vars interpoletion when we use scss variables inside css functions. This PR corrects it in all places I've found that scss variables were used.
References
Closes #4988.
Reviewer guidance