License description rectification

[rtibbles]

Summary

• Fixes a long standing bug in the sync command where license_description field was not synced from imported nodes
• Reinstates the previous syncing rectification code, but targets it specifically to license_description discrepancies and rectification.
• Removes the date filter, as this problem will affect any node that has ever been imported.

References

Fixes #4916

Reviewer guidance

Not sure if removing the date filter is going to make the query completely nonperformant - but it's only an extra two years? Not sure.

I think the fix is straight forward and neatly regression tested, so careful eyes on how I have modified the rectification script would be appreciated.

[bjester]

Seems good to me, just one question about channel publishing. I asked @ozer550 to take a look too

[bjester]

I know this was in the existing migration, but I also know that we did this in lockstep with emails we sent out. I'm not really sure if we should keep it or not.

[rtibbles]

Yeah, I would be fine with dropping this. @ozer550 does that make sense to you too?

[ozer550]

We still might want to republish it? as making changes to license field would result in changed=True, to_be_republished = not (base_channel.main_tree.get_family().filter(changed=True).exists()) this does the necessary check if there is some change that already exists and we would skip publishing for such cases.