Simple file validation and HTML5 zip correction#4867
Merged
rtibbles merged 4 commits intolearningequality:unstablefrom Jan 24, 2025
Merged
Simple file validation and HTML5 zip correction#4867rtibbles merged 4 commits intolearningequality:unstablefrom
rtibbles merged 4 commits intolearningequality:unstablefrom
Conversation
… Python implementation.
0ee8c0e to
d400681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #4013
Reviewer guidance
I think the 'first available html file' might be better handled by asking the user which one they want to use, but this would require a lot more work to enable.
Testing this is best done by taking an existing HTML5 app and messing about with it, unzip it, put its contents in a bunch of nested folders, and then rezip it. If appropriate, rename the index.html to something else and make sure it still works (this will only work reliably if there are no other html files in the root of the zip).