Implemented Method to check page number#4841
Implemented Method to check page number#4841rtibbles merged 6 commits intolearningequality:unstablefrom
Conversation
rtibbles
left a comment
There was a problem hiding this comment.
I have no doubt this is working, but it might be simpler to change this at the source when initially navigate to the search page. See where that happens here - you will note that we are currently preserving most of the existing query of the route, instead we should update the page to 1 there: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/frontend/channelEdit/views/ImportFromChannels/SearchOrBrowseWindow.vue#L178
I think you may be able to get this working with just a one line change there!
|
Hello @rtibbles that is an excellent suggestion. I shall change this by EOD. Thank you. |
|
Hello @rtibbles you may check now. Thanks for the suggestion. |
|
Hi @Arunima22 - this is looking great, thanks. I'll double check the behaviour, but I am pretty sure this can be merged! |
|
Just make sure to run this: |
|
@rtibbles yes okayy |
|
@rtibbles done |
|
Thanks @Arunima22! @rtibbles can we merge now? |
Summary
I have added a checkPageToLoad() Method in SearchResultsList.vue.
This method makes sure that fresh searches always load with Page One.
…
References
Here is the issue link: #4813 (comment)
…
Reviewer guidance
The reviewer, while trying to search for resources, should first search for a resource or keyword that will at least result in 11 search options and then navigate to page 2. Post navigating to page 2, the reviewer should search for something random that is likely to not produce any results. The fresh search will load with page one.
…