Properly handle metadata inheritance for non uploaded nodes in edit modal#4769
Merged
rtibbles merged 4 commits intolearningequality:unstablefrom Sep 27, 2024
Merged
Conversation
AlexVelezLl
reviewed
Sep 27, 2024
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Show resolved
Hide resolved
...ration/contentcuration/frontend/channelEdit/components/edit/InheritAncestorMetadataModal.vue
Show resolved
Hide resolved
AlexVelezLl
requested changes
Sep 27, 2024
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Code changes makes sense to me! And active logic now looks easier to understand. I just found one little bug on the first file upload after we had applied the "dont ask me again" option.
Compartir.pantalla.-.2024-09-27.16_04_00.mp4
… files. Use this to conditionalize explicit triggering of inheritance check.
AlexVelezLl
approved these changes
Sep 27, 2024
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thank you @rtibbles! Code changes looks good to me, and I havent found anything wrong on Manual QA. LGTM!
Member
Author
I think you mean:
:D |
Member
|
LGTM as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Fixes #4762
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)