Fixes topic tree not showing#4759
Merged
akolson merged 1 commit intolearningequality:unstablefrom Sep 26, 2024
Merged
Conversation
marcellamaki
approved these changes
Sep 26, 2024
Member
marcellamaki
left a comment
There was a problem hiding this comment.
I reviewed #4741 for context, and based on those changes, and the slack discussion, the updates here make sense to me for code review. I also checked manual QA for both the topic tree in the sidebar and pagination, and both seem to be working as expected. Thanks, Samson!
Merged
Member
|
LGTM as well! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This pr fixes a bug in the topics topics side panel where the topic tree is no longer being folded out. It also fixes a minor bug when select all is applied to a paginated list: the number of resources selected should reflect the number of resources currently displayed
Manual verification steps performed
Screenshots (if applicable)
Topic tree
Screen.Recording.2024-09-26.at.13.58.00.mov
Resource count
Screen.Recording.2024-09-26.at.14.07.36.mov
Does this introduce any tech-debt items?
Reviewer guidance
See manual verification steps above
Are there any risky areas that deserve extra testing?
References
Fixes #4756
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)