Fixes decline invitation#4750
Merged
akolson merged 9 commits intolearningequality:unstablefrom Sep 24, 2024
Merged
Conversation
LianaHarris360
requested changes
Sep 23, 2024
Member
LianaHarris360
left a comment
There was a problem hiding this comment.
I can confirm that declining and accepting the invitation works as expected and does not reappear when the page is loaded. There was just one thing I had a comment about that could possibly cause confusion.
LianaHarris360
approved these changes
Sep 24, 2024
Member
LianaHarris360
left a comment
There was a problem hiding this comment.
Accepting and declining an invitation to view and edit a channel works as expected and the code changes make sense to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This pr fixes the issue with a declined invitation popping up again. This fix updates the accept endpoint to allow for declining of invitations.
Manual verification steps performed
Screenshots (if applicable)
Screen.Recording.2024-09-23.at.21.44.49.mov
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Fixes #4743
Fixes #4744
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)