Follow up inheritable modal fixes

[marcellamaki]

Summary

Description of the change(s) you made

• Conditionalize helper text in modal to not display general inheritable metadata title when only language is inheritable
• Ensure that the InheritMetadataModal in the CurrentTreeView can be used again after it has completed handling inheritance for moved nodes
• Make the frontend extra field name match the backend inherited_metadata to ensure that preferences for users to 'don't display this modal again' are persisted

Manual verification steps performed

Create a new resource in a folder that only has language metadata set - confirm the non language related messaging in the modal doesn't display.
Move a resource into a folder that has inheritable metadata applied, apply the metadata. Move another resource into the same folder, confirm the modal shows again.
Upload a resource into a folder that has inheritable metadata applied, choose the 'don't show this modal again' option. Upload another resource into the same folder, and ensure that the metadata labels are also applied to this one, but that no modal displays.

Screenshots (if applicable)

Does this introduce any tech-debt items?

---

Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

Fixes #4699

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[akolson]

HI @rtibbles! I just did some QA and it appears that the modal is not displayed if bulk move is used. It is however displayed if just one resource is moved. See video for behavior.

Screen.Recording.2024-09-24.at.17.14.18.mov

[akolson]

Adding a blocker for the issue picked up during manual QA

[akolson]

Code changes make sense to me and manual QA seems to checkout. Requires more comprehensive testing, but should be good to go for now! Thanks @rtibbles