Fix multi select filters#4718
Merged
akolson merged 3 commits intolearningequality:unstablefrom Sep 9, 2024
Merged
Conversation
akolson
approved these changes
Sep 9, 2024
Member
akolson
left a comment
There was a problem hiding this comment.
Filters are now working correctly. Both code changes and manual QA checkout. Thanks @AlexVelezLl!
Member
|
Hi @AlexVelezLl - noticed just one minor issue: once I've selected a value from the filter when I reopen the same filter the list with items is not displayed in its default state (with the scroll bar up at the top): filters.default.state.mp4 |
Member
Author
|
Hi @pcenov! I see, but I suspect that this is not a regression from this PR. Could we have a follow up issue for this, please? :) |
Member
|
Hi @AlexVelezLl - certainly, here it is: #4721 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Add checkbox change handler that was missing to handle filter items selection.
Closes #4702
Manual verification steps performed
Screenshots (if applicable)
Compartir.pantalla.-.2024-09-09.09_19_18.mp4
Does this introduce any tech-debt items?
No
Reviewer guidance
How can a reviewer test these changes?
Play around with the languages filter in the content library tab.
References
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)