Remove KCard prototype files#4712
Merged
akolson merged 1 commit intolearningequality:unstablefrom Sep 5, 2024
Merged
Conversation
akolson
approved these changes
Sep 5, 2024
Member
There was a problem hiding this comment.
Changes look good and make sense to me! @MisRob, Any other thoughts on this, otherwise will proceed to merge?
Additional changes will need to be made to this component, but this is sufficient for now.
Thanks @AllanOXDi
Member
|
After chat with @MisRob, merging this! |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the latest KCard for the RecommendedResourceCard and remove the Studio KCard prototype files
Screenshots (if applicable)
Reviewer guidance
Call the RecommendedResourceCard anywhere you wish to use it.
Its worthy noting that RecommendedResourceCard might get disorted as the card width grows bigger but it will be fixed in this issue learningequality/kolibri-design-system#773
References
#4597
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)