Fixes frontend to properly call invitation accept endpoint.#4673
Merged
marcellamaki merged 1 commit intolearningequality:unstablefrom Aug 27, 2024
Merged
Conversation
marcellamaki
approved these changes
Aug 27, 2024
Member
marcellamaki
left a comment
There was a problem hiding this comment.
lgtm - changes from patch which was causing an error, and manual QA test confirms that i was able to accept the invitation and open the channel
Merged
Member
|
I was also able to accept the invitation and open the channel, but the invitation remained sticky on the top of My channels page even after clicking the ✔️ button several times, navigating away and back, and even after signing out and in again... I eventually had to decline the invitation (that I previously accepted!), in order to make it go away finally 🤷🏽 |
Member
|
cc @rtibbles |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Fixes oversight from #4615 where the frontend was not properly updated to use the new invitation accept API endpoint for synchronous acceptance of channel invitations
Manual verification steps performed
References
Fixes #4643
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)