Merged
Conversation
rtibbles
requested changes
Aug 22, 2024
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Everything is showing Changes saved now except for "What you will need", needs update in here: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/frontend/channelEdit/components/QuickEditModal/EditResourcesNeededModal.vue
marcellamaki
force-pushed
the
update-snackbar
branch
from
87c3167 to
6b6c73b
Compare
rtibbles
approved these changes
Aug 23, 2024
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Updates made in code and manually verified it.
Member
|
Regression tested at unstable with no regressions observed. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Fixes #4654
Adds a "changes saved" string to the shared translator.js file.
Manual verification steps performed
Made one edit for each possible bulk editing modal, and confirmed that the "Changes saved" string was displayed instead of the more specific string, per QA team idea
Screenshots (if applicable)
Does this introduce any tech-debt items?
I don't think so but the string linting disabling seems not ideal for common strings, but kind of out of scope
Reviewer guidance
How can a reviewer test these changes?
Edit each metadata option