Add validation for threshold none invalid cases#4642
Merged
rtibbles merged 2 commits intolearningequality:unstablefrom Aug 22, 2024
Merged
Add validation for threshold none invalid cases#4642rtibbles merged 2 commits intolearningequality:unstablefrom
rtibbles merged 2 commits intolearningequality:unstablefrom
Conversation
rtibbles
reviewed
Aug 20, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
One slight tweak to target this even more narrowly, but the test coverage looks good to me.
b2a2f0a to
230e65e
Compare
rtibbles
approved these changes
Aug 22, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
Changes look good, comments addressed - test coverage captures the error!
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add validation to automatically resolve cases where allowed none value of threshold was causing validation error.
Description of the change(s) you made
Manual verification steps performed
Does this introduce any tech-debt items?
Validation error would still come up for the cases where the changes just has a threshold field in it without the model information and may contradict with models that want it to be None. We would handle this in the frontend by reverting the optimistic changes.
References
closes #3879
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)