Fix checkbox issues#4629
Merged
rtibbles merged 10 commits intolearningequality:unstablefrom Aug 9, 2024
Merged
Conversation
rtibbles
reviewed
Aug 8, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
Code changes broadly make sense - screenshots give some confidence of the fixes! I'll take a quick through manually tomorrow to confirm.
24 tasks
akolson
approved these changes
Aug 9, 2024
Member
akolson
left a comment
There was a problem hiding this comment.
Manual QA checks out. Thanks @AlexVelezLl! cc @rtibbles
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Recently we removed VCheckbox from the studio codebase, so we updated the Checkbox wrapper component to use KCheckbox instead, but this has bring a number of inconsistencies that havent been resolved yet. (Probably after this PR there could be any other place with a wrong behaviour).
Manual verification steps performed
I have manually checked all instances of
<Checkbox>in the codebase and saw them rendered in the browser one by one.Screenshots
Reviewer guidance
How can a reviewer test these changes?
Check all checkboxes on studio and ensure they are working.
References
Closes #4525
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)