Fix incomplete resource importable#4618
Merged
AlexVelezLl merged 2 commits intolearningequality:unstablefrom Jul 30, 2024
Merged
Fix incomplete resource importable#4618AlexVelezLl merged 2 commits intolearningequality:unstablefrom
AlexVelezLl merged 2 commits intolearningequality:unstablefrom
Conversation
rtibbles
reviewed
Jul 24, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
Code changes make sense - I have not manually tested.
I keep wondering to myself, whether we should be using the indexedDB layer for this kind of listing, but it does perhaps still provide some value for high latency/unreliable connections.
akolson
approved these changes
Jul 30, 2024
Member
akolson
left a comment
There was a problem hiding this comment.
Changes look correct to me! Also, Manual QA checks out! Thanks @AlexVelezLl!
Member
Author
|
Thank you @akolson!! |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Description of the change(s) you made
Avoid listing incomplete resources in "import from channels" view.
Manual verification steps performed
Screenshots (if applicable)
Given this incomplete resource:

Before:
After:
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
References
Closes #4088
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)