#4599 - context manager send task_id queryset only to delete task_id

[Keshav123454]

Summary

Description of the change(s) you made

Manual verification steps performed

1. Step 1
2. Step 2
3. ...

Screenshots (if applicable)

Does this introduce any tech-debt items?

---

Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[ozer550]

Hi @Keshav123454! The solution you have implemented here seems to fulfill the requirements mentioned in #4599, there's a bit more of cleaning that needs to be done. The CustomTaskMetadata object needs to be properly deleted along with TaskResult object when the publish task is failed. As I have been assigned this issue already, I have mostly worked with it and now I'm working with the tests.

[ozer550]

Hi @Keshav123454! The solution you have implemented here seems to fulfill the requirements mentioned in #4599, there's a bit more of cleaning that needs to be done. The CustomTaskMetadata object needs to be properly deleted along with TaskResult object when the publish task is failed. As I have been assigned this issue already, I have mostly worked with it and now I'm working with the tests.

#4620 PR for reference.

[Keshav123454]

Hi @Keshav123454! The solution you have implemented here seems to fulfill the requirements mentioned in #4599, there's a bit more of cleaning that needs to be done. The CustomTaskMetadata object needs to be properly deleted along with TaskResult object when the publish task is failed. As I have been assigned this issue already, I have mostly worked with it and now I'm working with the tests.

Thank you for the review.

[MisRob]

@Keshav123454 I will close this now but we appreciate your effort. Please always message us on an issue you'd like to work on and wait for being assigned - this will prevent from these kinds of situations. You can see the contributing guidelines with more details.

There are contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:

• Kolibri Contributing Guidelines
• Kolibri Design System Contributing Guidelines
• Studio Contributing Guidelines

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.