Upload bloom format files in studio#4590
Conversation
rtibbles
left a comment
There was a problem hiding this comment.
Let's update to the published le-utils version, and just make sure we're using the code generation script.
contentcuration/contentcuration/migrations/0149_auto_20240612_1847.py
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/leUtils/FormatPresets.js
Outdated
Show resolved
Hide resolved
rtibbles
left a comment
There was a problem hiding this comment.
As long as automated checks pass, this should be good to go.
nucleogenesis
left a comment
There was a problem hiding this comment.
Just a question about the tests change, but overall this LGTM
| expect(wrapper.vm.primaryFileMapping[1].file.id).toBe('file-3'); | ||
| expect(wrapper.vm.primaryFileMapping[2].file.id).toBe('file-1'); |
There was a problem hiding this comment.
Were these failing before or just not testing what they were supposed to test?
There was a problem hiding this comment.
They were just brittle to the order of file presets - because the bloompub preset happened to go before epub and pdf, (because alphabetical) it moved them each down a place.
|
I confirm that it's possible to upload bloom files. There's no preview of the files and they cannot be imported in Kolibri which I guess will be implemented at a later stage. |
Summary
Description of the change(s) you made
I have added the bloompub preset in the contentcuration le-utlis shared folder to allow users to upload bloom files in the studio
Screenshots
References
#4583
#36
Comments
When uploading the bloom file from our PC the File object created on frontend is not able to detect the mimetype of the file and hence sending null to backend in the type property. Should we hardcode it othe front endnd for this format?
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)