Adds new LE logo#4523
Merged
marcellamaki merged 3 commits intolearningequality:hotfixesfrom Apr 24, 2024
Merged
Conversation
bjester
requested changes
Apr 22, 2024
Member
bjester
left a comment
There was a problem hiding this comment.
It looks to me the dimensions on the image tags aren't quite correct to the aspect ratio of the original image. It's possible VImg maintains the correct aspect ratio regardless, but would be good for it to match for clarity if we define both width and height (sometimes defining both is unnecessary)
The new logo's inherit dimensions are 456px by 305px.
Having a target height H: W = 456 / 305 * H
Having a target width W: H = 305 / 456 * W
Member
Author
|
Sure, Blaine! Let me try this and revert. |
Member
Author
|
@bjester, I think we should be good now with the dimensions. |
Member
Member
bjester
approved these changes
Apr 24, 2024
Member
bjester
left a comment
There was a problem hiding this comment.
I approve! @marcellamaki would you double check?

Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Description of the change(s) you made
This pr updates studio to use the new LE logo
Manual verification steps performed
Content Creationtab.Screenshots (if applicable)
Before

After

Does this introduce any tech-debt items?
NA
Reviewer guidance
How can a reviewer test these changes?
Content Creationtab.References
Fixes #4521
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)