Added missing checkbox label#4512
Merged
MisRob merged 5 commits intolearningequality:unstablefrom Apr 19, 2024
Merged
Conversation
Member
|
Thank you, @BabyElias! For context for reviewers, the issue this PR is resolving may be a regression related to recent #4472 |
ozer550
requested changes
Apr 16, 2024
Member
ozer550
left a comment
There was a problem hiding this comment.
The code changes work! But I think, we should be consistent with how we are using HelpTooltip in other places of the code i.e it should be within a <template>.
contentcuration/contentcuration/frontend/channelList/views/Channel/CatalogFilters.vue
Show resolved
Hide resolved
Member
|
Thanks both! |
24 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change(s) you made
Added missing checkbox label text
Screenshots (if applicable)
Before :


After :
Does this introduce any tech-debt items?
No
Reviewer guidance
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)