Welcoming kcard to studio#4466
Closed
AllanOXDi wants to merge 29 commits intolearningequality:unstablefrom
Closed
Conversation
akolson
reviewed
Mar 7, 2024
| <li class="remove-list-style"> | ||
| <component | ||
| :is="'h' + headingLevel" | ||
| v-if="title !== null" |
Member
There was a problem hiding this comment.
- I don't think conditional display is necessary since heading level is a required prop. If you need to add conditional display, i think it would be best suited for
TextTuncatorcomponent that holds thetitle. I'm not entirely sure but I think hiding theh<2-6>component would hinder click event propagation since we are looking at having the entire card responding to clicks. This we can clarify with Misha - It's also worth considering using a computed prop for the
:isvalue
akolson
reviewed
Mar 7, 2024
| <div | ||
| :class="$computedClass({ ':focus': $coreOutline })" | ||
| > | ||
| <li class="remove-list-style"> |
Member
There was a problem hiding this comment.
According to the spec, I think this should be the outer most layer, for accessibility reasons
akolson
reviewed
Mar 7, 2024
| v-if="layout === 'horizontal'" | ||
| > | ||
| <component | ||
| :is="'div'" |
Member
There was a problem hiding this comment.
I think simply just is="div" would eliminate the need to pass a wrapped string('div')
akolson
reviewed
Mar 7, 2024
Member
There was a problem hiding this comment.
I think more generally we could improve how we are swapping the layouts and thumbnails. I feel this is quite verbose and we may run into maintainability issues pretty quickly. Maybe we can start by asking a few questions on the dynamicity of the proposed layouts.
- Which of the components in the layouts is dynamic (keeps on changing their position)?
- How can we structure our markup to meet the ever changing demands of the identified component?
- What changes when the different layouts are specified?
I think would help us implement a more maintainable structure.
Member
Author
|
This needs to be closed to make way for #4480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)