Conversation
|
Hii @bjester , can you please review it?. So that I'll have better idea, if I have to work more on this or it is enough. |
bjester
left a comment
There was a problem hiding this comment.
@Abhishekzod007 I left some comments on your solution here
|
|
||
| send_mail( | ||
| "Kolibri Studio storage request", | ||
| f"Kolibri Studio storage request from {self.request.user}", |
There was a problem hiding this comment.
@Abhishekzod007 This change is unrelated to the issue referenced in the PR description.
There was a problem hiding this comment.
I think it was a mistake by me
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
89eb121 to
cc2828a
Compare
|
@bjester please review |
|
Hii @bjester , I done the changes that you told me to do. I have push the changes in the PR. |
|
@Abhishekzod007 This looks good, but with one linting issue below. I still see the change for #4418 included here, but since you've now been assigned, we can include that here and close the issue when you complete the unit test. There's one linting error: https://github.com/learningequality/studio/actions/runs/8224272224/job/22575306609?pr=4436#step:6:28 |
|
Hi @bjester,I have fixed the linting issue, thanks |
Summary
Description of the change(s) you made
Firstly I found out the position where that particular file is located and it took a lot of time to find and then did some changes there by putting and deleting values so that I can check updates on the actual website. This is an attempt to solve issue #4171
Manual verification steps performed
Reviewer guidance
I have only changed the value of that particular width.
References
Closes #4171
Includes update for #4418 (minus tests TBC)
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)