double submit issue resolved#4414
Merged
LianaHarris360 merged 2 commits intolearningequality:unstablefrom Jan 30, 2024
GarvitSinghal47:Double-Submit-error
Merged
double submit issue resolved#4414LianaHarris360 merged 2 commits intolearningequality:unstablefrom GarvitSinghal47:Double-Submit-error
LianaHarris360 merged 2 commits intolearningequality:unstablefrom
GarvitSinghal47:Double-Submit-error
Conversation
LianaHarris360
requested changes
Jan 29, 2024
Member
LianaHarris360
left a comment
There was a problem hiding this comment.
Hi @GarvitSinghal47 thank you for working on this. The failing JavaScript Linting test will need to be fixed before this pr can be approved and merged. You can manually run the auto-formatters with yarn run lint-frontend:format, or install pre-commit hooks to automatically have this done when you commit changes, more about this can be found in the Kolibri developer documentation.
Also, if you include a brief description of the changes you made and any instructions on how we can test those changes, that would assist us in reviewing your PR quicker.
LianaHarris360
approved these changes
Jan 30, 2024
Member
LianaHarris360
left a comment
There was a problem hiding this comment.
The changes look great and correctly fix the accidental creation of multiple channel collections. Thank you!
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4144
Summary
Description of the change(s) you made
I've added a new state mechanism to prevent concurrent save operations. Previously, multiple clicks on the save button could trigger simultaneous saves, leading to potential issues.
Changes Made:
Added a saving state to prevent multiple save operations.
Purpose:
This ensures that a save/submit operation must complete before another one can be initiated, preventing unintended side effects.
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)