Updated Components to KComponents

[BabyElias]

Summary

Updated IconButton to use KComponents (KIcon & KIconButton) instead. This is the part of a series of changes, to be made under Issue #219 in Kolibri Design System.

Description of the change(s) you made

learningequality/kolibri-design-system#219

Screenshots (if applicable)

The icons that have been changed

Comments

Could not find the Bin icon under Icons, so used delete icon for Delete Channel dropdown option.

Contributor's Checklist

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[BabyElias]

Also, I have been trying to find out where the components of /contentcuration/contentcuration/frontend/channelEdit/components/Clipboard/index.vue are located while hosting the website locally so that I can visually test for the changes that I am making to it. Any help would be really appreciated!

[MisRob]

Hi @BabyElias, thank you and I also appreciate your diligence, it's always helpful when authors of pull request test all the places.

Also, I have been trying to find out where the components of /contentcuration/contentcuration/frontend/channelEdit/components/Clipboard/index.vue are located while hosting the website locally so that I can visually test for the changes that I am making to it. Any help would be really appreciated!

I didn't check the particular file right now, but Clipboard is this feature (see the icon in the bottom right corner):

Perhaps you're already using it, but if that's not the case, Vue Devtools can help with locating components in some cases.

[BabyElias]

Okay,
thank you @MisRob !

[akolson]

Hi @BabyElias! Generally, the changes look great. However, regarding the "bin" icon, I think the one you are looking for is the trash icon. I also think making like-for-like replacement is equally important in this process to keep the UI consistent.

[BabyElias]

Thanks for pointing that @akolson! Made the required changes.

[nucleogenesis]

Thanks for your continued work on this @BabyElias -- I'll leave final approval to @akolson but this looks good to me

[akolson]

Thanks @BabyElias! LGTM.

[akolson]

@BabyElias, please feel free to let us know in case there are other issues in our backlog that you would like to contribute to. Your contribution is very much appreciated.