Improve errors reporting in edit modal#4404
Merged
AlexVelezLl merged 4 commits intolearningequality:unstablefrom Jan 24, 2024
Merged
Improve errors reporting in edit modal#4404AlexVelezLl merged 4 commits intolearningequality:unstablefrom
AlexVelezLl merged 4 commits intolearningequality:unstablefrom
Conversation
Contributor
Author
AlexVelezLl
requested changes
Jan 18, 2024
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Hi @FidalMathew! 👋
This is pretty exciting, we'll finally have more specific error messages in the edit view 🎉. The code overall looks good! I have left you some comments to take into account small details.
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditView.vue
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@AlexVelezLl thank you for the review and quick response. I have made the changes, could you review them? |
AlexVelezLl
reviewed
Jan 23, 2024
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Hi! @FidalMathew Thank you! Code looks good to me! And I think the scroll behavior is as expected.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
The approach used to improve error reporting in the edit modal is by getting all the errors list. Mapping that errorsList with their names and reference objects. Using that reference object we'll be using scrollIntoView to allow the user to direct themselves to the required input left blank.
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Some changes that needs to add to the current PR are:
scrollIntoViewmoves into view a bit below the actual input element.Reference
The PR is in reference with issue: #2924
Reviewer guidance
How can a reviewer test these changes?
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)