Make ContentNode Menus Keyboard accessible#4402
Merged
AlexVelezLl merged 3 commits intolearningequality:studio-usability-enhancementsfrom Jan 18, 2024
Merged
Make ContentNode Menus Keyboard accessible#4402AlexVelezLl merged 3 commits intolearningequality:studio-usability-enhancementsfrom
AlexVelezLl merged 3 commits intolearningequality:studio-usability-enhancementsfrom
Conversation
akolson
reviewed
Jan 18, 2024
| modal: QuickEditModals.WHAT_IS_NEEDED, | ||
| nodeIds: [this.nodeId], | ||
| }); | ||
| quickEditModalFactory(modal) { |
akolson
reviewed
Jan 18, 2024
| nodeIds: [this.nodeId], | ||
| }); | ||
| const trackActionLabel = modal.replace(/_/g, ' ').toLowerCase(); | ||
| this.trackAction(`Edit ${trackActionLabel}`); |
Member
There was a problem hiding this comment.
Just checking this is not string that requires translation?
Member
Author
There was a problem hiding this comment.
Oh no, these are strings just for analytics purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Catch keyboard focus when contentNode menus are opened. Added conditional render to menus since Vuetify just mounts the menu once by default, and this does not allow the
mountedordestroyedhooks to be executed.Manual verification steps performed
Verified that these menus are keyboard-accesible now:
Screenshots (if applicable)
Compartir.pantalla.-.2024-01-17.08_59_51.mp4
Reviewer guidance
How can a reviewer test these changes?
References
Closes #4369
Comments
Keyboard navigation is not entirely consistent for now (the outline color changes for example) But this would be solved when the menu is updated to
KDropdownMenu.Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)