admin-panel collection error resolved#4401
Merged
ozer550 merged 3 commits intolearningequality:unstablefrom Feb 6, 2024
GarvitSinghal47:error-channel-collection
Merged
admin-panel collection error resolved#4401ozer550 merged 3 commits intolearningequality:unstablefrom GarvitSinghal47:error-channel-collection
ozer550 merged 3 commits intolearningequality:unstablefrom
GarvitSinghal47:error-channel-collection
Conversation
ozer550
reviewed
Jan 31, 2024
Member
|
After having a quick conversation with @bjester, We have decided to go forward with the prior way of creating the queryset i.e we don't want to do it all in one go, apologies for this @GarvitSinghal47! One thing to note here is your earlier commit was filtering first and then doing the annotation to the queryset which could become problematic. The right way would be to first annotate and then to filter with edit=True. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #4145
Summary
Description:
In the current setup, the frontend was fetching and displaying all channels without properly handling the edit flag or checking if the channels were associated with the current user_id. This inconsistency led to sporadic issues where channels would sometimes show up in the admin list and sometimes not.
Changes Made:
Modified the frontend logic to only fetch and display channels where edit is set to true or the user_id matches the current user.
Ensured proper handling to prevent channels from being displayed inconsistently in the admin list.
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)