Upgrade to python 3.10#4384
Merged
rtibbles merged 1 commit intolearningequality:unstablefrom Jan 17, 2024
Merged
Conversation
rtibbles
reviewed
Jan 10, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
Thanks for this - a quick skim over the code gave me no cause for concern - just one repeated typo and one question.
Will need to do some manual testing before approval.
rtibbles
reviewed
Jan 10, 2024
113cee5 to
cfa2079
Compare
cfa2079 to
cbfa811
Compare
rtibbles
approved these changes
Jan 17, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
Local manual testing checks out. This is good to merge. Thank you @Jovian-Dsouza !
4 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
make dcbuildthenmake dcupand everything ran fine through dockerdocker build -f k8s/images/app/Dockerfile .and built the production image successfullyDoes this introduce any tech-debt items?
No this removes tech-debt
Reviewer guidance
How can a reviewer test these changes?
As mentioned above
Are there any risky areas that deserve extra testing?
References
Solves #4211
Comments
We can also consider updraging to Node 18.x since Node 16.x is deprecated
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)