Fix node availability when propagating import copy#4377
Merged
bjester merged 1 commit intolearningequality:unstablefrom Jan 18, 2024
Merged
Fix node availability when propagating import copy#4377bjester merged 1 commit intolearningequality:unstablefrom
bjester merged 1 commit intolearningequality:unstablefrom
Conversation
bjester
approved these changes
Jan 18, 2024
Member
bjester
left a comment
There was a problem hiding this comment.
This looks like the right change to me. Since this occurs in handling remote changes, this is unlikely to break anything, but we will test this during pre-release QA.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Here I've fixed the
undefined original_source_node_id TypeError. After importing a contentnode, when this change was getting relayed to the other channel editor, we were getting that error on the other channel editor's end because the contentnode which has to be imported was not present in the Indexed DB.Investigation credits to our ironman @bjester. Code credits to me.
Manual verification steps performed
Reviewer guidance
Manual verification steps should be enough.
References
Closes #4332.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)