Changed IconButton to KRouterLink#4374
Merged
nucleogenesis merged 5 commits intolearningequality:unstablefrom Jan 11, 2024
Merged
Changed IconButton to KRouterLink#4374nucleogenesis merged 5 commits intolearningequality:unstablefrom
nucleogenesis merged 5 commits intolearningequality:unstablefrom
Conversation
contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.vue
Outdated
Show resolved
Hide resolved
nucleogenesis
requested changes
Jan 9, 2024
Member
nucleogenesis
left a comment
There was a problem hiding this comment.
Just a couple of changes in the StagingTreePage/index.vue updates here.
Overall this is the exact right direction! Thanks so much @BabyElias for this submission!
contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.vue
Outdated
Show resolved
Hide resolved
Member
Author
|
Thank you so much for your feedback! |
contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.vue
Outdated
Show resolved
Hide resolved
nucleogenesis
approved these changes
Jan 11, 2024
Member
nucleogenesis
left a comment
There was a problem hiding this comment.
Thanks @BabyElias I've tested this locally and all looks good! Feel free to tag me for review on any follow-up issues you create along these lines.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated IconButton to use KComponents (KRouterLink, KIcon & KIconButton) instead.
Description of the change(s) you made
learningequality/kolibri-design-system#219
Screenshots (if applicable)
The icons that have been changed
Reviewer guidance
How can a reviewer test these changes?
This is just a trial PR to confirm that I am headed in the right direction or not.
If this pull request is accepted and merged, I plan to submit additional pull requests addressing other issue with more extensive changes. The current pull request contains only minor modifications related to that issue.
Contributor's Checklist
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)