Changed the router-link tag to KrouterLink#4293
Changed the router-link tag to KrouterLink#4293MisRob merged 1 commit intolearningequality:unstablefrom
Conversation
Signed-off-by: shivangrawat30 <rawatshivang30@gmail.com>
akolson
left a comment
There was a problem hiding this comment.
Thanks @ShivangRawat30! Your changes look correct to me. 🎉
Tagging @radinamatic @pcenov for the final round of manual QA before a merge can happen
|
@akolson Would it be possible to have some details of what would be the best approach for the manual QA? Any specific steps or parts of the application that need deeper testing? Is there a user workflow that is the most likely to break because of the changes in this PR, etc.? |
|
@radinamatic. However, there are two others that I failed to figure out where they belong on the UI. Hopefully this helps |
|
Thanks @ShivangRawat30!
As soon as you continue, could you please reference the updated places in a PR description, similarly to how @akolson did in the comment above? I assume that you test those places manually as you work, so it should be just a moment of taking a screenshot. It doesn't need to be extremely detailed, only so that our QA team knows what places to click through. It would be very helpful for smooth review process. |
|
@MisRob I will make sure to incorporate this into my future contributions. Thank you for your guidance. |
|
Merging as @pcenov mentioned he will be testing this in |


This pull request replaces occurrences of the
router-Linktag withKrouterLink.Summary
Description of the change(s) you made
learningequality/kolibri-design-system#219
Reviewer guidance
How can a reviewer test these changes?
If this pull request is accepted and merged, I plan to submit additional pull requests addressing other issue with more extensive changes. The current pull request contains only minor modifications related to that issue.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)