Super Duper Fast Import Search 🚀#4279
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Sep 13, 2023
Merged
Conversation
Member
Author
|
@bjester the failing test has no relation with the code changes here and to double check I ran that test locally and its passing, so this is safe to merge. |
Member
|
I'll defer approval of the code changes to someone else, but confirming manual QA of import search works as expected |
Member
|
Seemed to just be a flaky test - failure disappeared on rerun. |
rtibbles
approved these changes
Sep 13, 2023
Member
rtibbles
left a comment
There was a problem hiding this comment.
Interesting - I thought as they were excluded from the values call, these annotations wouldn't have any impact - apparently not!
Member
|
Tested and verified at Hotfixes - searching for resources when importing from other channels is functioning correctly. |
Member
Author
|
Thanks @pcenov! 🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This PR makes import from other channel search super fast (reduced query time by almost half) by removing annotations that are no longer needed due to Kolibri public API providing those information.
Manual verification steps performed
Just make sure that import search works.
Reviewer guidance
How can a reviewer test these changes?
Making sure that import search works should make this PR good to go.
References
Closes #4266.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)