Fix missing attributes from change objects#4278
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Sep 13, 2023
Merged
Fix missing attributes from change objects#4278rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles merged 1 commit intolearningequality:hotfixesfrom
Conversation
Member
|
Confirming that manual QA checks out here for both move and delete operations - the state correctly updates in the other user's browser (no matter who is making the change) without any errors in the console |
rtibbles
approved these changes
Sep 13, 2023
Member
rtibbles
left a comment
There was a problem hiding this comment.
Code changes look correct, and accord with the defined fields in the Change classes.
Member
|
No issues observed while manually testing this one as well! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This PR fixes frontend errors due to missing attributes on change objects. Particularly fixes the move and delete operations.
oldObjandparentwere missing in move operation andoldObjwas missing for delete operation.Manual verification steps performed
Reviewer guidance
How can a reviewer test these changes?
Performing manual verification steps should be enough.
References
Closes #4209.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)