Implementation to extract metadata from H5P Content Package#4131
Merged
rtibbles merged 5 commits intolearningequality:unstablefrom Aug 14, 2023
Merged
Conversation
- implement code to extract .h5p files metadata;
e8c0173 to
7b4608c
Compare
c7bb7f3 to
3a2b734
Compare
rtibbles
reviewed
Jul 7, 2023
Member
rtibbles
left a comment
There was a problem hiding this comment.
I think in the future we may want to distinguish between the file metadata and the node metadata specifically, but for now, I think this will work.
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
- override file title
rtibbles
reviewed
Jul 11, 2023
Member
rtibbles
left a comment
There was a problem hiding this comment.
A little bit of code cleanup, and just need a test to give us some assurance here and it should be good to go.
contentcuration/contentcuration/frontend/shared/vuex/file/utils.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/vuex/file/utils.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
rtibbles
reviewed
Aug 8, 2023
Member
rtibbles
left a comment
There was a problem hiding this comment.
A couple of tweaks in the tests, but this is looking ready to go!
contentcuration/contentcuration/frontend/shared/vuex/file/__tests__/module.spec.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/vuex/file/utils.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/vuex/file/__tests__/module.spec.js
Outdated
Show resolved
Hide resolved
- [lint] fixes
5350a65 to
3f68c51
Compare
rtibbles
approved these changes
Aug 14, 2023
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code aims to extract metadata from H5P content package.
This Pr is a part of GSoC Project linked with the issue #4081.
Summary
Description of the change(s) you made
getH5PMetadataManual verification steps performed
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)