Skip to content

Comments

Remove additional files upon channel sync#4027

Merged
rtibbles merged 1 commit intolearningequality:unstablefrom
vkWeb:sync-files
Apr 17, 2023
Merged

Remove additional files upon channel sync#4027
rtibbles merged 1 commit intolearningequality:unstablefrom
vkWeb:sync-files

Conversation

@vkWeb
Copy link
Member

@vkWeb vkWeb commented Apr 17, 2023

Summary

This PR fixes sync_node_files algorithm to remove additional files from imported / copied nodes.

Manual verification steps performed

  1. Create a PDF file type contentnode and copy it.
  2. Add an EPUB document to the copied node.
  3. Sync channel by clicking on three-dot menu then 'Sync resources' and then make sure 'Files' option is ticked and click on 'Continue'.
  4. Notice in the backend database the additional EPUB of the copied node no longer exists.

Reviewer guidance

Does manual verification and unit test passes?

References

Closes #3818.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense and test covers the relevant case. Thanks @vkWeb!

@rtibbles rtibbles merged commit c9cbc62 into learningequality:unstable Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync Resources: Syncing of files does not delete additional files

2 participants