Migrate python-kms to 2.0.0#4019
Merged
bjester merged 3 commits intolearningequality:unstablefrom May 10, 2023
Merged
Conversation
bjester
requested changes
Apr 25, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
Could you use zlib for the crc32 checksum instead of adding a new dependency? Like this
Member
Ah this is crc32c not crc32, which I guess isn't builtin with zlib |
bjester
approved these changes
May 10, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
One dependency change by me, but approving so we can test it in CD
Member
|
CD completed successfully and the unstable server is still functioning appropriately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pr intends to make the required changes to upgrade the python-kms library to its newest major release 2.0.0.
fixes #3885
Description of the change(s) you made
Are there any risky areas that deserve extra testing?
There maybe some changes that I have missed, but I tried my best to catch most of them! If there are some changes missed I will be happy to debug them and make the required changes.
Comments
Additionally added the crcmod package for checksum mechanism as described here.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)