Skip to content

Comments

Disables "Move here" button in copy workflow once it has been clicked #4009

Merged
marcellamaki merged 2 commits intolearningequality:unstablefrom
marcellamaki:disable-move-here-button
Apr 17, 2023
Merged

Disables "Move here" button in copy workflow once it has been clicked #4009
marcellamaki merged 2 commits intolearningequality:unstablefrom
marcellamaki:disable-move-here-button

Conversation

@marcellamaki
Copy link
Member

Summary

Description of the change(s) you made

Fixes #3940

This PR adds an additional condition that would make the button disabled - when the move has been initiated. It also adds a small loading spinner to indicate that the move is in progress

Manual verification steps performed

  1. Use devtools to set connection speed to slow 3G
  2. Copy a number of resources to clipboard
  3. Move to another folder

Screenshots (if applicable)

move-here.mp4

Reviewer guidance

How can a reviewer test these changes?

Please see the steps outline under manual verification. Using the slow connection, and having a long-ish list of resources to be moved is important to actually see this happen.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @marcellamaki. I encountered the following issue that seems to be present in this PR while not on the latest unstable: When I want to move resources to a nested sub-topic, I can't click the move button because it is disabled already, even when I haven't initiated moving resources yet.

EDIT: I realized that the button should be disabled in this case, because I attempted to move them to a location where they are already, so apologies. So it's only the loader that shouldn't be present in this case.

Peek 2023-04-04 13-55

@MisRob
Copy link
Member

MisRob commented Apr 4, 2023

And another issue is that when I attempt to move a resource after I previously moved another one, the button is disabled and I can't move it:

loading

When I was reading through the code, I noticed that this.moveNodesInProgress is set to true at some point but I didn't notice any code that would reset it back to false. Wondering if it may be related?

@marcellamaki
Copy link
Member Author

@MisRob - you are right. good catch with the resetting the state here. I think I've solved both of the scenarios you mention here, both the incorrect loading display and also the not reset after a move has completed. Thank you!

@marcellamaki marcellamaki requested a review from MisRob April 13, 2023 17:59
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marcellamaki, new code changes make sense to me.

@marcellamaki marcellamaki merged commit 74eb388 into learningequality:unstable Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double copy of files from clipboard when moving them

2 participants