Disables "Move here" button in copy workflow once it has been clicked #4009
Conversation
…s been initiated and add circular loader
There was a problem hiding this comment.
Thank you, @marcellamaki. I encountered the following issue that seems to be present in this PR while not on the latest unstable: When I want to move resources to a nested sub-topic, I can't click the move button because it is disabled already, even when I haven't initiated moving resources yet.
EDIT: I realized that the button should be disabled in this case, because I attempted to move them to a location where they are already, so apologies. So it's only the loader that shouldn't be present in this case.
|
And another issue is that when I attempt to move a resource after I previously moved another one, the button is disabled and I can't move it: When I was reading through the code, I noticed that |
|
@MisRob - you are right. good catch with the resetting the state here. I think I've solved both of the scenarios you mention here, both the incorrect loading display and also the not reset after a move has completed. Thank you! |
MisRob
left a comment
There was a problem hiding this comment.
Thank you @marcellamaki, new code changes make sense to me.


Summary
Description of the change(s) you made
Fixes #3940
This PR adds an additional condition that would make the button disabled - when the
movehas been initiated. It also adds a small loading spinner to indicate that the move is in progressManual verification steps performed
Screenshots (if applicable)
move-here.mp4
Reviewer guidance
How can a reviewer test these changes?
Please see the steps outline under manual verification. Using the slow connection, and having a long-ish list of resources to be moved is important to actually see this happen.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)