Updates mp3 resource previewer metadata to include has captions and s…#3999
Merged
bjester merged 2 commits intolearningequality:unstablefrom Mar 23, 2023
Merged
Conversation
Member
|
@LianaHarris360 Another thing that would be good to tackle is to do a similar migration that we performed when we automatically set 'has captions' for videos. You could update the existing command to operate on audio nodes instead, because we already ran it in production and won't need to run it again. Note: I believe the preset is still |
… nodes with subtitles
Member
Author
|
@bjester The command has been updated to handle audio nodes now 👍 |
Member
|
@radinamatic no issues observed - the metadata info for audio accessibility is displayed correctly now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ubtitles
Summary
Description of the change(s) you made
This PR updates the previewer to correctly display 'Accessibility' and 'Captions and Subtitles' data for audio resources.
AccessibilityCategoriesMaphas been updated to include the content kindaudioand maps toCAPTIONS_SUBTITLES.ResourcePanelhas been updated to display 'Captions and Subtitles' for audio resources as as well as video resources.Manual verification steps performed
Screenshots (if applicable)
References
Fixes #3876
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timeStudio-specifc:
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)