Levels and categories in channel details modal#3990
Merged
rtibbles merged 4 commits intolearningequality:unstablefrom Apr 7, 2023
Merged
Levels and categories in channel details modal#3990rtibbles merged 4 commits intolearningequality:unstablefrom
rtibbles merged 4 commits intolearningequality:unstablefrom
Conversation
marcellamaki
approved these changes
Mar 29, 2023
Member
marcellamaki
left a comment
There was a problem hiding this comment.
This looks good and manual QA checks out for both the in-Studio display and PDF download.
My only (non-blocking) question is - can you remind me, did we decide to remove the parent category for category display? i.e. "Mathematics", though it also checks the "school" checkbox in the form, actually doesn't display the chip for "school" in the form, or in the details (at either the resource or channel level)
Just want to make sure this was an intentional change -- I think it was? -- and not a side effect of refactoring somewhere along the line.
Member
Author
|
Yes, pretty sure it was intentional to prevent display bloat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
References
Fixes #3877