Consolidate agreement opt-ins during account creation#3895
Merged
bjester merged 8 commits intolearningequality:unstablefrom Jan 27, 2023
AllanOXDi:changedCreateAccount
Merged
Consolidate agreement opt-ins during account creation#3895bjester merged 8 commits intolearningequality:unstablefrom AllanOXDi:changedCreateAccount
bjester merged 8 commits intolearningequality:unstablefrom
AllanOXDi:changedCreateAccount
Conversation
bjester
reviewed
Jan 5, 2023
contentcuration/contentcuration/frontend/accounts/pages/Create.vue
Outdated
Show resolved
Hide resolved
bjester
requested changes
Jan 6, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
Please revert the contactMessage string back to its original form-- see my comment about the reasons why. Also, it appears some JS tests for account creation are failing, and they likely need updated to handle only one checkbox. You can run it with:
yarn run test-jest contentcuration/contentcuration/frontend/accounts/pages/__tests__/create.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to consolidate the sign-up experience for users in Studio. Currently, a first-time user has to agree to two mandatory opt-ins at sign-up Terms of Service and privacy policy these processes are separated and require users to complete multiple steps to fully sign up. Consolidating these processes into a single, cohesive flow will make it as simple and straightforward as possible for users to opt-in or sign up in Studio.
closes #3834
Manual verification steps performed
Screenshots (if applicable)
Before


After:
figma
https://www.figma.com/file/1tQQ0Sw1yDjzO66hyjLVPM?node-id=556:4666#323944643
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)