Skip to content

Fix markdown conversion for assessments#3870

Merged
bjester merged 3 commits intolearningequality:hotfixesfrom
rtibbles:assessment_tweaks
Dec 7, 2022
Merged

Fix markdown conversion for assessments#3870
bjester merged 3 commits intolearningequality:hotfixesfrom
rtibbles:assessment_tweaks

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented Dec 7, 2022

Summary

Description of the change(s) you made

  • Removes unnecessary reordering of HTML to MD conversion that was causing MD to be unnecessarily escaped
  • Adds regression test
  • Removes regression caused by applying 'editing' to all custom components
  • Sets 'editing' attribute only in the MarkdownEditor component

Manual verification steps performed

  1. Add an image to a question

  2. Publish the channel

  3. Confirm the image is in the exercise (on a local machine can search your .minio_data folder for the perseus file and confirm that the archive contains the image

  4. Confirm that the Image context menu only appears when the markdown is being displayed in edit mode.

  5. Confirm that it does not appear when the markdown is displayed in view only.

…down.

Add regression test to make guarantee about markdown conversion.
@rtibbles rtibbles requested a review from bjester December 7, 2022 00:51
@bjester
Copy link
Member

bjester commented Dec 7, 2022

LGTM!

@bjester bjester merged commit 88d7008 into learningequality:hotfixes Dec 7, 2022
@radinamatic
Copy link
Member

Images are fully present on Kolibri and can now be successfully removed from the exercise on Studio! 👏🏽

image-removed

2022-12-07_18-23-14

@bjester bjester mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants