Skip to content

Comments

Added bullet points between languages on sign-in page#3854

Merged
bjester merged 2 commits intolearningequality:unstablefrom
LianaHarris360:missing-bullet-points
Dec 5, 2022
Merged

Added bullet points between languages on sign-in page#3854
bjester merged 2 commits intolearningequality:unstablefrom
LianaHarris360:missing-bullet-points

Conversation

@LianaHarris360
Copy link
Member

Summary

Description of the change(s) you made

This pr fixes the language bar on the sign-in page so that the bullet points are correctly displayed.

Manual verification steps performed

See #3384

Screenshots (if applicable)

Before
Before-en
Before-ar

After
After-en
After-ar


Reviewer guidance

How can a reviewer test these changes?

  1. Go to /en/accounts/#/ and observe the language section. The bullet points should be displayed between the languages correctly.

References

Closes #3384

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@LianaHarris360 LianaHarris360 marked this pull request as ready for review December 1, 2022 15:32
@bjester bjester merged commit 6a10c68 into learningequality:unstable Dec 5, 2022
@LianaHarris360 LianaHarris360 deleted the missing-bullet-points branch December 5, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unstable - Sign in page - Missing bullet points between the languages

2 participants